⚡ Reuse internal collections in Dijkstra.Solve - #143
Conversation
Co-authored-by: johnstrand <11484777+johnstrand@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What:
Reused internal instance collections (
_distances,_previousNodes,_visited, and_queue) across calls toDijkstra<T>.Solveinstead of allocating newDictionary,HashSet, andPriorityQueueobjects on every pathfinding query.🎯 Why:
Instantiating new tracking data structures on every
Solvecall causes unnecessary per-call GC heap allocations and overhead during shortest-path calculations.📊 Measured Improvement:
BenchmarkDotNet results for
DijkstraBenchmarks.SolveBenchmark:PR created automatically by Jules for task 13125347420987556613 started by @johnstrand