⚡ optimize IEnumerable.Shuffle to use ArrayPool - #141
Conversation
Replaced List<T> materialization in CollectionExtensions.Shuffle with ArrayPool<T>.Shared to eliminate heap allocations during intermediate array resizes. Co-authored-by: johnstrand <11484777+johnstrand@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What:
Optimized
CollectionExtensions.Shuffle<T>to useArrayPool<T>.Sharedfor intermediate materialization when shufflingIEnumerable<T>sources with unknown non-enumerated count.🎯 Why:
Previously, shuffling sequences with an unknown non-enumerated count materialized elements into a
List<T>. As items were added,List<T>repeatedly reallocated larger internal arrays on the heap (4 -> 8 -> 16 -> 32...), generating unnecessary GC allocations and returning oversized arrays.📊 Measured Improvement:
Using
ArrayPool<T>.Sharedfor intermediate resizes and returning rented buffers back to the pool eliminates all GC allocations during enumeration and resizing.PR created automatically by Jules for task 2486375890888135087 started by @johnstrand