⚡ Optimize AABB intersection methods by eliminating allocations and redundant math - #138
⚡ Optimize AABB intersection methods by eliminating allocations and redundant math#138johnstrand wants to merge 1 commit into
Conversation
…edundant math Co-authored-by: johnstrand <11484777+johnstrand@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Optimized
AABB.Intersectsoverloads forPolygon2D,Circle,Vector2 center/radius, andVector2 start/end.🎯 Why:
Intersects(Polygon2D)was redundantly recalculating polygon bounds on the fly despitepolygon.BoundingBoxalready being pre-computed on construction.Intersects(Vector2 center, float radius)was instantiatingnew Circle()on the heap on every invocation.Intersects(Vector2 start, Vector2 end)was constructingnew Line(), which performed unnecessary calculations for line length, midpoint, and normal vectors.📊 Measured Improvement:
IntersectsInside: 18.49 ns → 7.21 ns (61% faster)IntersectsIntersecting: 20.01 ns → 8.77 ns (56% faster)IntersectsContainsAABB: 68.70 ns → 61.45 ns (10.5% faster)✨ Result: All 413 unit tests pass cleanly.
PR created automatically by Jules for task 10479672689742488225 started by @johnstrand