⚡ optimize ConcurrentHashSet.IntersectWith to prevent ToHashSet allocations - #132
Conversation
Avoid allocating a full HashSet via ToHashSet() when intersecting with an IEnumerable that does not implement ICollection<T>. Co-authored-by: johnstrand <11484777+johnstrand@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
⚡ What: Optimized
ConcurrentHashSet<T>.IntersectWithto iterateotherand collect matches into a sized set bounded by_dictionary.Count, short-circuiting when all elements are matched, avoiding unboundedToHashSet()allocations whenotheris anIEnumerable<T>.🎯 Why: Previously, if
otherwas not anICollection<T>,other.ToHashSet()was called, creating memory allocations proportional to the size ofother.📊 Measured Improvement: Eliminates allocations proportional to
other.Countfor non-ICollection<T>inputs down to at most_dictionary.Countmatching elements, with fast short-circuiting when all local keys are found.PR created automatically by Jules for task 4274503267266574944 started by @johnstrand