Skip to content

⚡ optimize ConcurrentHashSet.IntersectWith to prevent ToHashSet allocations - #132

Merged
johnstrand merged 2 commits into
masterfrom
perf/concurrent-hashset-intersectwith-4274503267266574944
Aug 21, 2026
Merged

⚡ optimize ConcurrentHashSet.IntersectWith to prevent ToHashSet allocations#132
johnstrand merged 2 commits into
masterfrom
perf/concurrent-hashset-intersectwith-4274503267266574944

Conversation

@johnstrand

Copy link
Copy Markdown
Owner

What: Optimized ConcurrentHashSet<T>.IntersectWith to iterate other and collect matches into a sized set bounded by _dictionary.Count, short-circuiting when all elements are matched, avoiding unbounded ToHashSet() allocations when other is an IEnumerable<T>.
🎯 Why: Previously, if other was not an ICollection<T>, other.ToHashSet() was called, creating memory allocations proportional to the size of other.
📊 Measured Improvement: Eliminates allocations proportional to other.Count for non-ICollection<T> inputs down to at most _dictionary.Count matching elements, with fast short-circuiting when all local keys are found.


PR created automatically by Jules for task 4274503267266574944 started by @johnstrand

Avoid allocating a full HashSet via ToHashSet() when intersecting with an IEnumerable that does not implement ICollection<T>.

Co-authored-by: johnstrand <11484777+johnstrand@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@johnstrand
johnstrand merged commit 39ad895 into master Aug 21, 2026
1 check passed
@johnstrand
johnstrand deleted the perf/concurrent-hashset-intersectwith-4274503267266574944 branch August 21, 2026 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant