src cmake performs library build - #2
Open
n9wxu wants to merge 2 commits into
Open
Conversation
jmcglad
reviewed
Jul 24, 2026
| static char uint8_to_hex_char(const uint8_t n) | ||
| { | ||
| static const hex[] = { | ||
| static const char hex[] = { |
jmcglad
reviewed
Jul 24, 2026
| @@ -1,4 +1,6 @@ | |||
| # FIXME: Add installation directives for libgps | |||
| cmake_minimum_required(VERSION 3.25) | |||
Owner
There was a problem hiding this comment.
It doesn't seem right to put cmake_minimum_required() in anything other than the top-level CMakeLists.txt file. What's the effect of cmake_minimum_required() being called multiple times in a project?
jmcglad
requested changes
Jul 25, 2026
jmcglad
left a comment
jmcglad
left a comment
Owner
There was a problem hiding this comment.
Sorry for taking so long to get to this. Until recently, I hadn't been paying attention to my old projects on GitHub. I'd like to know more about your reasoning for the changes to src/CMakeLists.txt. I always sort of intended for the source files gps.c and gps.h to be vendored into other projects. I made that clearer in the latest update to the README. So, I'm not sure that file needs to be changed. I would like to take your change to gps.c though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I changed the CMakeLists.txt in the src folder so that it will successfully be incorporated into another project with add_subdirectory.
I have NOT tested this with the tests in this repo.