Skip to content

Fix version URL and refactor PMV initialization #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hbokh wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −3
Open

Fix version URL and refactor PMV initialization #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions lib/channel.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,9 @@ class Channel
def initialize(channel, platform, pmv)
@channel = channel
@platform = platform

# If Apple hasn't released any recent Rapid Security Responses,
# the relevant JSON will be empty.
@pmv = pmv[channel][platform].nil? ? Array.new : pmv[channel][platform]
@pmv = pmv[channel]&.[](platform) || []
end

def highest_version(versions)
Expand Down Expand Up @@ -113,7 +112,7 @@ def security_link(version)
if version_link.nil?
rapid_channel? ? rapid_index_url : security_index_url
else
apple_support_url + version_link[:href]
version_link[:href]
end
end

Expand Down