fix: use exec to eliminate redundant bash wrapper processes - #120
Open
uhs-robert wants to merge 1 commit into
Open
fix: use exec to eliminate redundant bash wrapper processes#120uhs-robert wants to merge 1 commit into
uhs-robert wants to merge 1 commit into
Conversation
Without exec, launching a session leaves two persistent bash processes: tmuxifier-load-session waiting on tmuxifier-tmux, which waits on tmux. With exec, each script replaces itself so only the tmux process remains.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without exec, launching a session leaves two persistent bash processes: tmuxifier-load-session waiting on tmuxifier-tmux, which waits on tmux. With exec, each script replaces itself so only the tmux process remains.
Problem
Launching a session via
tmuxifier load-sessionleaves two persistent bash processes alive for the lifetime of the session:tmuxifier-load-sessionwaits ontmuxifier-tmuxwhich then waits ontmux. Both bash processes sit idle consuming memory with no useful work left to do after tmux has finished launching.Fix
Use
execin two places so each script replaces itself rather than forking a child:libexec/tmuxifier-tmux:exec tmux ...replaces the bash process with tmux directlylib/layout-helpers.sh__go_to_session():exec tmuxifier-tmux ...replaces thetmuxifier-load-sessionprocess, which then execs into tmuxResult
Only the
tmuxprocess remains, no leftover bash wrappers.