feat: add multi-repository review picker - #20
Open
ileadall42 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A Herdr workspace can contain agent panes from several Git repositories, especially when a top-level project is composed of multiple checkouts. The existing review actions intentionally follow the focused pane, but that makes it easy to review the wrong repository/base or send comments to the wrong agent when several repositories are active.
Changes
review:pickfor explicit repository, base branch, and feedback-agent selectionsend-review:pickso an open review can be sent to any live agent selected at delivery time<base>...HEADrange and persist the chosen agent association for latersend-reviewThe new send-time picker has no plugin-wide default key because likely
prefix+alt+...candidates can collide with Herdr defaults. Users with a freed key can bindjhochenbaum.hunkdiff.send-review:pickexplicitly.Validation
npm run checknpm run buildnpm test(28 files, 686 tests)npm audit --audit-level=high --registry=https://registry.npmjs.org/(0 vulnerabilities)review:picksuccessfullyRelated to #15: the picker makes the comparison base explicit instead of assuming a single repository/base for the whole workspace.