R6 combined: macOS x64 leg, pool production wiring, deterministic tests + native-rotation campaign - #5
Merged
Merged
Conversation
DecodedRgba.appliedOrientation (default 1) and DngOrientingFullDecoder
typedef (second typedef, DngFullDecoder stays byte-identical) plus
residualExifOrientation({declared, applied}), a total D4-composition
helper that lets multi-arm decoder dispatch report what orientation it
already applied and Halcyon apply only the residual.
…ve-rotation-spec) Adds DngOrientingFullDecoder? orientingDngDecoder to PhotoSource, selected in decodePhase/decodePhaseExpensive over dngDecoder when non-null. Adds dispatchOrientingFullDecode routing only the RAW arm to an orienting decoder (heif/jxl/tiff report appliedOrientation:1, unchanged). dng_decode_service.dart gains a pass-through production binding since the pinned ceyx package has no oriented entry yet (lands with spec Tasks 3-5). usePointer at photo_source.dart:615 is byte-identical (AC-8.2). New test file covers AC-8.1-8.5 against a fake orienting decoder. Co-Authored-By: Claude <noreply@anthropic.com>
…k 7) Compute _ExifTransform from residualExifOrientation(declared, applied) in all three entry points (decodedRgbaToImage, decodedRgbaToPixelPayload, decodedRgbaToOrientedFullRes), so a natively-oriented RAW frame hits the identity short-circuit and keeps its native buffer instead of paying a GPU round trip. orient| probe line gains applied=/residual= (append-only, existing fields frozen). Adds TC-1086..1089 covering AC-7.1/7.2/7.5 and the extended probe format. Co-Authored-By: Claude <noreply@anthropic.com>
…64 docs un-parked
…d reference) + wiring tests + trim suppression
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combined PR per user ruling (option 1): R6 parked-items round + macOS x64 enablement + pool production wiring, co-landing with the native-rotation campaign's three commits (790ce1a/edc010e/a03b513) whose history is entangled with this round's on the shared tree.
R6 commits: a1a4b3e (hard staged-decoder arch gate + arch stamp), 84976c4 (macos-x64 CI leg, decoder-arch + multi-symbol assertions), 6babcf5 (condition-driven test waits), c67db8e (WorkingSetTrim.suppressed definition — repairs edc010e's forward reference — + pool wiring tests).
Verified at c67db8e by independent verifier: x64 leg 7/7 assertions failed=0 skipped=0 on a fresh cross-compiled build (decoder byte-identical to the v0.1.16 pin digest); arm64 leg re-proven live 6/6 incl. functional FFI probe; arch stamp fires both directions; compile-only CI intact.
Known non-claims: Intel-hardware runtime loadability is not proven by CI (no Intel runner); bisect window edc010e..6babcf5 does not compile (repaired at c67db8e, documented).
🤖 Generated with Claude Code