SDK-Update and new options - #8
Open
giraone wants to merge 11 commits into
Open
Conversation
- New operations RANDOM_GET, RANDOM_READ_FIRST_BYTE added - Code refactoring (replacement of deprecated methods) due to new AWS SDK
- Code refactoring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request contains
I have tested the change with AWS S3, minio and RedHat Ceph.
Option --region was needed get the test running against minio. The option --prefix is intended to place the test objects in "folders". I found it useful in my tests.
With the new SDK the existing RANDOM_READ has created warnings in each request, because the object was not read to the end. So I decided to offer 3 methods: