docs: show the Trendshift daily-Kotlin award on the README and landing hero - #285
Conversation
…g hero Markleaf reached #1 Kotlin repository of the day on Trendshift (23 Jul 2026). The badge goes on both public surfaces, in all six languages, with the alt text translated the way the demo clips already are. The two surfaces embed it differently on purpose. The READMEs use Trendshift's live badge URL: GitHub proxies README images through camo, so a reader never contacts Trendshift and the badge stays accurate on its own. GitHub Pages proxies nothing, so the landing pages serve a checked-in copy of the SVG instead — embedding the live URL there would have every visitor's browser hit a third party, on the page whose whole argument is that Markleaf does not phone home. docs/assets/README.md records that trade-off and how to refresh the file. Verified: check-landing-overflow.mjs passes (12 pages x 6 widths, no horizontal overflow) and verify-landing-versions.ps1 still passes; a headless render confirms the SVG loads and sits inside the hero on all six pages at 320px and 1280px; GitHub's markdown API confirms the README embed survives sanitisation with its link, dimensions and alt intact. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d66cfc671d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <a class="hero-award" href="https://trendshift.io/repositories/58116?utm_source=trendshift-badge&utm_medium=badge&utm_campaign=badge-trendshift-58116"> | ||
| <img src="assets/trendshift-daily-kotlin.svg" width="250" height="55" alt="Markleaf — #1 Kotlin repository of the day on Trendshift"> |
There was a problem hiding this comment.
This adds the award to the public README and landing surfaces, but the commit updates neither CHANGELOG.md nor HISTORY.md. The repository requires user-impacting changes to be recorded in the changelog and every work unit to be logged in project history, so add the corresponding entries before merging.
AGENTS.md reference: AGENTS.md:L219-L223
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Half of this is right, and it is fixed in 1367b22.
HISTORY.md — agreed. AGENTS.md:222 asks for a work-unit entry, and PR #282 (a docs-only landing and README change) set the precedent by logging one. Added.
CHANGELOG.md — not applicable here. CHANGELOG.md is strictly version-sectioned (## vX.Y.Z - Title - YYYY-MM-DD) and is the literal source the release job's awk parser cuts GitHub release notes from — AGENTS.md:229-231 makes that dependency explicit, and the job fails on test -s release-title.txt if the shape breaks. There is no Unreleased section, and this PR carries no version bump, so recording it would mean either inventing a version section or editing v2.32.1's already-tagged and already-published release notes. Nothing about the app changed either: the badge is on the README and the landing hero, and an APK built before and after this commit is identical.
AGENTS.md:219 also scopes that list to 코드 변경 시 — when code changes. PR #282 is the nearest analogue and updated HISTORY without touching CHANGELOG, which is the same call.
The reasoning is recorded in the HISTORY entry so the question does not have to be re-litigated next time.
Codex review flagged the missing documentation record. AGENTS.md keeps a work-unit entry in HISTORY.md for every change, and PR #282 — a docs-only landing and README change — set the precedent. The same review also asked for a CHANGELOG entry. That half does not apply: CHANGELOG.md is strictly version-sectioned and is the source the release job's awk parser cuts GitHub release notes from, it has no Unreleased section, and this change carries no version bump, so an entry would mean inventing a version or editing v2.32.1's already-published notes. Nothing about the app changed. The HISTORY entry records that reasoning. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
1 participant
Markleaf reached #1 Kotlin repository of the day on Trendshift (23 Jul 2026). This puts the badge on both public surfaces, in all six languages.
What changed
a.hero-awardin the hero copy block, directly under the release line.landing.css— one 3-line rule (display: inline-block+ top margin). The globalimgrule already handlesmax-width: 100%.docs/assets/trendshift-daily-kotlin.svg— new, 3.7 KB, self-contained (no external refs, no scripts, internal gradient ids only).docs/assets/README.md— records why the file is checked in and how to refresh it.Why the two surfaces embed it differently
The READMEs use Trendshift's live badge URL. GitHub proxies README images through camo, so a reader never contacts Trendshift, and the badge stays accurate on its own.
GitHub Pages proxies nothing. Embedding the live URL there would have every visitor's browser hit a third party — on the page whose whole argument is that Markleaf does not phone home. So the landing pages serve a checked-in copy instead. The cost is that it no longer follows the live badge, which is fine: it records a dated achievement, not a current standing.
Deviations from the snippet Trendshift hands out:
target="_blank" rel="noopener noreferrer"dropped (GitHub strips both and substitutesrel="nofollow"; no other external link in these files carries them), and the URL-encodedaltreplaced with translated text, matching how the demo clips are already handled.Verification
scripts/check-landing-overflow.mjsscripts/verify-landing-versions.ps1gh api -X POST markdownon the README headerwidth/heightandaltall survive sanitisation; image resolves through camo200 image/svg+xml, SVG text reads#1 Repository Of The Day·TRENDSHIFTDocs only — no app code touched.
🤖 Generated with Claude Code