Replace MS Sans Serif font with correct conversion#230
Open
akx wants to merge 1 commit into
Open
Conversation
|
@akx is attempting to deploy a commit to the jdan's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the slightly-incorrect hand-built-by-Lou MS Sans Serif replica with a pixel-and-metric-perfect conversion of the original Windows 98 font.
For evidence, I present an animation of Visual Basic running in pcjs's Windows 3.0 machine rendering MS Sans Serif 8pt Bold, alternately overlaid with a node screenshot capture of this branch's 98.css.
You can find the conversion tooling here.