Harden auth flow, CSP, and UI event handling - #79
Merged
Conversation
Agent-Logs-Url: https://github.com/jamesjhs/Tasker/sessions/0d3e6b03-297c-4119-8d17-3add73d86fff Co-authored-by: jamesjhs <168957462+jamesjhs@users.noreply.github.com>
Agent-Logs-Url: https://github.com/jamesjhs/Tasker/sessions/0d3e6b03-297c-4119-8d17-3add73d86fff Co-authored-by: jamesjhs <168957462+jamesjhs@users.noreply.github.com>
Agent-Logs-Url: https://github.com/jamesjhs/Tasker/sessions/0d3e6b03-297c-4119-8d17-3add73d86fff Co-authored-by: jamesjhs <168957462+jamesjhs@users.noreply.github.com>
Agent-Logs-Url: https://github.com/jamesjhs/Tasker/sessions/0d3e6b03-297c-4119-8d17-3add73d86fff Co-authored-by: jamesjhs <168957462+jamesjhs@users.noreply.github.com>
Agent-Logs-Url: https://github.com/jamesjhs/Tasker/sessions/0d3e6b03-297c-4119-8d17-3add73d86fff Co-authored-by: jamesjhs <168957462+jamesjhs@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
jamesjhs
May 26, 2026 08:45
View session
Copilot
AI
changed the title
Harden trust proxy handling and Excel export sanitization
Harden auth flow, CSP, and UI event handling
May 26, 2026
jamesjhs
marked this pull request as ready for review
May 26, 2026 15:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change implements the requested medium‑severity hardening: enforce CSRF on logout, tighten 2FA handling, remove inline handlers to allow stricter CSP, enforce production session secrets, and add login/2FA rate limits. It addresses the plan items end‑to‑end without altering core app behavior.
/api/auth/logoutSESSION_SECRETrequired in productionALLOW_2FA_LOG_FALLBACKscript-src-attr 'none'to disallow inline handlerson*handlers withdata-actiondispatch and centralized event delegationhistory.back()handlers in static help/policy/dpia/guide pagesExample (inline handler → delegated action):