release: v0.1.1 - #157
Merged
Merged
Conversation
Coerce empty-string PIN to None in CreateRoom/UpdateRoom validators so the model validator surfaces 'A private room needs a PIN.' instead of the misleading 'PIN must be 4-6 digits.'. Add client-side PIN validation in the create-room modal to block submission and show an inline message. Closes #142
fix(rooms): clear error when creating private room without PIN
Point the compose `app` service at ghcr.io/jaherhum/crowdroom:latest and move the local build into docker-compose.override.yml so `docker compose up` still builds for dev while `docker compose -f docker-compose.yml up` pulls the published image. Refs #150
chore(docker): reference GHCR image in compose with local build override
The eager-load tests queried the module-level engine and only skipped when no rows existed, so they raised OperationalError on a schema-less database (e.g. CI). Replace that with a seeded temporary-SQLite fixture that patches the service engine, so both tests exercise the relation load deterministically. Also mock _get_current_queue_item in the track-mismatch test; the poll loop reads it unconditionally, so the unmocked call hit the real database and was swallowed by the catch-all, leaving _advance_queue uncalled.
test(playback): isolate poller tests from the shared SQLite database
Add ci.yml (ruff + pytest gates and a no-push Docker build on PRs to develop/main and pushes to main) and release.yml (build and push the image to ghcr.io/jaherhum/crowdroom with latest + sha tags on push to main). Also add the missing docstring on ConnectionType so ruff check passes, unblocking the lint gate. Closes #151 Closes #145
ci: add GitHub Actions for lint/test, PR image build, and GHCR publish
jaherhum
added
Kind/Chore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Release v0.1.1. Promotes the accumulated
developwork tomainand bumps the project version. Merging this triggersrelease.yml, which builds and publishes the Docker image to GHCR.Related issue
closes #145
closes #150
closes #151
Type of change
Changes
chore(release): bump version0.1.0→0.1.1(pyproject.toml+uv.lock).ConnectionType(bug(lint): D101 missing docstring on ConnectionType #145).Testing
CI (lint + pytest + docker build) passed green on the contributing PRs against develop.
Checklist
.envand secrets are not includedAdditional notes
First tagged release. After merge, tag
v0.1.1onmain. Therelease.ymlworkflow publishesghcr.io/jaherhum/crowdroom:latest+sha-<commit>on push to main.