Fix bigWig zoom summaries across sparse gaps - #103
Open
Rehpotsirhc-z wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bigWig writer can produce zoom summaries for regions where no data was written. In this example, I use pybigtools, but the main bigtools writer is also affected. The full-resolution records correctly show an empty gap, but the zoomed query reports values throughout it.
I also wrote the same sparse input using pyBigWig for comparison, along with pybigtools before and after the patch in this PR. Here's what it looks like in IGV, where pybigtools shows signal across the gaps:
This PR clamps
add_startto at leastcurrent_val.start, which matches the equivalent logic already used in the bigBed writer.