Report syntax property bundle errors as syntax-property-bundle#832
Merged
Conversation
Both bundle-building reducers delegated their duplicate checks to rebellion's into-hash and into-sorted-map, so duplicate paths and keys were reported in terms of those internal helpers. Build the bundle's sorted map with fold reducers that raise the error directly, naming syntax-property-bundle and including the offending path. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
|
Docs preview: https://resyntax.notjack.space/preview/832/ |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Resyntax analyzed 1 file in this pull request and found no issues.
|
coverage: 96.521% (+0.004%) from 96.517% — fix-property-bundle-error-source-830 into master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #830.
Both reducers now build the bundle's sorted map with a fold that checks for duplicates itself, so the error names
syntax-property-bundleinstead ofinto-hash/build-sorted-mapand reports the offending path.🤖 Generated with Claude Code