Clear EQ_Constraints in Domain::clearAll() (fixes leak + stale non-empty domain after wipe) - #33
Open
nmorabowen wants to merge 1 commit into
Open
Conversation
Domain::clearAll() (invoked by wipe()) empties every tagged-object container it owns -- elements, nodes, SP/PC/MP constraints, load patterns, parameters -- except theEQs. The EQ_Constraint objects therefore survived a wipe: they were never freed (memory leak) and, because getNumComponents() stayed nonzero, the domain still reported itself as non-empty afterward. Add the missing theEQs->clearAll() alongside the other constraint containers. No effect on a model that holds no EQ_Constraints. Co-authored-by: Patricio Palacios <pxpalacios@miuandes.cl> Co-authored-by: Jose A. Abell <jaabell@miuandes.cl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Domain::clearAll()(called bywipe()) empties every tagged-object container it owns — elements, nodes, SP/PC/MP constraints, load patterns, parameters — excepttheEQs. SoEQ_Constraintobjects survived a wipe: never freed (leak), and sincetheEQs->getNumComponents()stayed nonzero the domain still reported itself non-empty afterward.Fix: add the missing
theEQs->clearAll()next to the other constraint containers. No effect on a model that holds noEQ_Constraints.Authors: Nicolas Mora Bowen, Patricio Palacios, José A. Abell