Skip to content

Replace confirm dialogs on edit/delete failures with exponential backoff #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sakfa wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Replace confirm dialogs on edit/delete failures with exponential backoff #100

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 32 additions & 21 deletions powerdeletesuite.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,6 +408,7 @@ var pd = {
});
},
createProcessStream: function () {
pd.backoff.reset();
window.pd_processing = true;
pd.exportItems = [];
pd.exportIds = [];
Expand Down Expand Up @@ -548,6 +549,22 @@ var pd = {
});
},
},
backoff: {
delay: 1000,
maxDelay: 1024000,
schedule: function (fn) {
console.log(
"[PowerDeleteSuite] Rate limited (429). Backing off for " +
pd.backoff.delay / 1000 +
"s before retrying..."
);
setTimeout(fn, pd.backoff.delay);
pd.backoff.delay = Math.min(pd.backoff.delay * 2, pd.backoff.maxDelay);
},
reset: function () {
pd.backoff.delay = 1000;
},
},
helpers: {
validate: function () {
if (pd.task.config.isEditing && pd.task.config.editText === "") {
Expand Down Expand Up @@ -885,22 +902,18 @@ var pd = {
},
}).then(
function () {
pd.backoff.reset();
pd.task.items[0].pdDeleted = true;
pd.actions.children.handleSingle();
},
function () {
function (jqXHR) {
pd.task.info.errors++;
if (
confirm(
"Error deleting " +
(item.kind == "t3" ? "post" : "comment") +
", would you like to retry?"
)
) {
pd.actions.children.handleSingle();
if (jqXHR.status === 429) {
pd.backoff.schedule(function () {
pd.actions.children.handleSingle();
});
} else {
pd.actions.children.finishItem();
pd.actions.children.handleGroup();
pd.actions.children.handleSingle();
}
}
);
Expand Down Expand Up @@ -929,21 +942,19 @@ var pd = {
},
}).then(
function () {
pd.backoff.reset();
pd.task.items[0].pdEdited = true;
pd.actions.children.handleSingle();
},
function () {
function (jqXHR) {
pd.task.info.errors++;
if (
!confirm(
"Error editing " +
(item.kind == "t3" ? "post" : "comment") +
", would you like to retry?"
)
) {
item.pdEdited = true;
if (jqXHR.status === 429) {
pd.backoff.schedule(function () {
pd.actions.children.handleSingle();
});
} else {
pd.actions.children.handleSingle();
}
pd.actions.children.handleSingle();
}
);
} else {
Expand Down