app-updater: minOsVersion gating, optional notes, macOS permission fixes (#565) - #609
Merged
Merged
Conversation
- set umask to 022 in updater install script - normalize installed app bundle permissions after copy - enforce root:wheel ownership and readable/traversable modes for users - fail update and restore backup if permission normalization fails #565
…uired version Add optional minOsVersion field support in update.json. When present, the auto-update checker silently skips the notification if the running OS is older than the required version. The manual "Check for updates" dialog shows an informational message instead. Backward-compatible: omitting the field applies no restriction.
…nt daemon rights regressions (#565) - keep restrictive-umask mitigation via umask 022 in update install script - remove updater-side chmod/chown normalization step from execution path - document why normalization is disabled (daemon requires strict rights for bundled static files in Contents/Resources/etc) - retain normalization snippet as commented reference only #565
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
app-updater: minOsVersion gating, optional notes, macOS permission fixes (#565)
Summary
Changes
-
minOsVersionOS compatibility gatingAdds support for an optional
minOsVersionfield in the update JSON. When present:Supported format:
"X","X.Y", or"X.Y.Z"(e.g."12"for macOS 12+,"10.0.19041"for Windows 10 build 19041+).The check fails open - if the OS version cannot be parsed, the update is shown.
- Optional
generic.notesin the update dialogThe update dialog now renders
generic.notes(if present in the update JSON) as pre-formatted text above the release notes section.- macOS updater: umask and permission handling (#565)
umask 022at the top ofinstall.shso files copied during an update are world-readable even when the parent process runs with a restrictive umask (e.g.077).Testing
minOsVersionexceeds current OSminOsVersionis met or absentgeneric.notesrenders above release notes; absent field renders nothingumask 077