Fix enrich-history not discovering cluster_ids from scan-only databases - #27
Merged
iross merged 1 commit intoAug 24, 2026
Merged
Conversation
…sk-35) enrich_from_condor_history() only discovered candidate cluster_ids from the events table (built by db build from NDJSON). A provenance.db populated purely via scan --db (an ad hoc batch with no DAGMan/NDJSON instrumentation at all) has an empty events table, so enrich-history reported "No new cluster_ids to enrich" even though those exact jobs were already sitting in condor_history waiting to be enriched further. Candidate cluster_ids are now the union of the events table and whatever's already in condor_history (any source), so a scan-only database is a valid input to enrich-history too. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
iross
deleted the
fix/enrich-history-discovers-condor-history-cluster-ids
branch
August 24, 2026 20:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
enrich_from_condor_history()only discovered candidate cluster_ids from theeventstable (built bydb buildfrom NDJSON). Aprovenance.dbpopulated purely viascan --db(an ad hoc batch with no DAGMan/NDJSON instrumentation at all) has an emptyeventstable, soenrich-historyreported "No new cluster_ids to enrich" even though those exact jobs were already sitting incondor_historywaiting to be enriched further.eventstable and whatever's already incondor_history(any source).Test plan
uv run pytest tests/ -q— 278 passed, 2 skippedruff check/ty checkcleanscan --dbinto a fresh db, thenenrich-history— now attempts the query instead of reporting nothing to do🤖 Generated with Claude Code