Add progress output to db enrich-history - #23
Merged
Conversation
enrich_from_condor_history() ran silently until it returned, printing only a final summary line -- no sign of life across many batched condor_history queries, and no explanation when there was nothing to enrich (e.g. events table not built yet, or --db pointed at the wrong file) beyond an unexplained wall of zeros. Adds an optional on_progress callback, invoked before the first query with the total cluster_id/batch count, after each batch with running totals, and with a clear reason when there's nothing to do. Wired to typer.echo in `mldag-query db enrich-history` so it prints live; defaults to a no-op so existing callers are unaffected. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
enrich_from_condor_history()ran completely silently until it returned, printing only a final summary line — no sign of life across many batchedcondor_historyqueries.eventstable not built yet, or--dbpointed at the wrong file), it printed an unexplained wall of zeros with no indication why — this is exactly what surfaced in testing today.on_progresscallback: called before the first query with the total cluster_id/batch count, after each batch with running totals, and with a clear reason ("No new cluster_ids to enrich.") when there's nothing to do. Wired totyper.echoinmldag-query db enrich-history.Test plan
uv run pytest tests/ -q— 276 passed, 2 skippedruff check/ty checkclean on touched files🤖 Generated with Claude Code