Fix window size growing with client-side decorations

[City-busz]

Save the current client size with gtk_window_get_size() instead of using the cached window dimensions. This prevents the saved size from gradually increasing when using client-side decorations on Wayland.

Summary by Sourcery

Bug Fixes:

• Prevent saved window dimensions from gradually growing when client-side decorations are used on Wayland.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Window configuration persistence now queries GTK for the current window size before saving, preventing client-side decoration offsets from causing the restored size to grow over time on Wayland.

Sequence diagram for corrected window size persistence

sequenceDiagram
    participant GTK as GTK Window
    participant WC as WindowConfig
    participant Store as Configuration Store

    GTK->>WC: on_configure_event(window, event, user_data)
    WC->>GTK: gtk_window_get_size(window, width, height)
    GTK-->>WC: current client width and height
    WC->>WC: SetWidth(width).SetHeight(height)
    WC->>Store: Save()

Loading

File-Level Changes

Change	Details	Files
Persist the actual current GTK window size rather than configure-event dimensions.	Declare width and height outputs for the GTK size query. Call gtk_window_get_size() during configuration handling and save the returned dimensions. Replace event->width/event->height with the queried client size to avoid cumulative growth with client-side decorations on Wayland.	src/iptux/WindowConfig.cpp

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Needs a human reviewer. If the size calculation is wrong, the application may persist incorrect window dimensions in its configuration, causing an affected window to reopen at the wrong size after reverting the code. The stored value is bounded and can be corrected by resizing or rewriting the configuration.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[lidaobing]

@City-Bus build failed.

../src/iptux/WindowConfig.cpp: In static member function ‘static gboolean iptux::WindowConfig::on_configure_event(GtkWidget*, GdkEventConfigure*, gpointer)’:
../src/iptux/WindowConfig.cpp:31:62: error: unused parameter ‘event’ [-Werror=unused-parameter]
   31 |                                           GdkEventConfigure* event,
      |                                           ~~~~~~~~~~~~~~~~~~~^~~~~
cc1plus: all warnings being treated as errors

[sonarqubecloud]

Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE