fix: Ipfs-Uri gateway header (IPIP-548) - #11437
Open
lidel wants to merge 2 commits into
Open
Conversation
Bump boxo to the IPIP-548 implementation (ipfs/boxo#1209): gateway responses carry a canonical percent-encoded Ipfs-Uri header and stop sending the deprecated X-Ipfs-Path, which cannot represent every UnixFS file name. - sharness: CORS expects Ipfs-Uri exposed, X-Ipfs-Path gone - gateway-conformance CI pinned to the IPIP-548 test suite (ipfs/gateway-conformance#301) until a release ships - reverse-proxy doc and v0.44 changelog updated Refs ipfs/specs#548
Expose boxo's opt-in for the legacy X-Ipfs-Path response header as a kubo config flag, default off. Unsafe: the legacy value cannot represent every UnixFS file name, so it must only be used to facilitate migration to Ipfs-Uri, and even when enabled the header is still skipped when the value would include non-ASCII byte sequences. Refs ipfs/specs#548
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
lidel
marked this pull request as ready for review
August 23, 2026 23:54
This was referenced Aug 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Legacy
X-Ipfs-Pathcannot carry every UnixFS file name: bytes outside visible ASCII are invalid in HTTP field values1, so names likełódź.txtreached clients garbled. ipfs/specs#548 deprecates it in favor ofIpfs-Uri, a percent-encodedipfs:///ipns://address that survives any name.Fix
Ipfs-Uriheader, andX-Ipfs-Pathis no longer sentGateway.DeprecatedXIpfsPathrestores the legacy header to ease migration; even then it is skipped when the value would include non-ASCII byte sequencesdocs/config.md, and the reverse-proxy doc explain the migrationDraft until boxo cuts a release with ipfs/boxo#1209; the temporary
go.modpin then becomes a normal version bump.Footnotes
RFC 9110, section 5.5: field values are limited to HTAB, SP, and visible ASCII. ↩