Add three new public interfaces - #549
Merged
Merged
Conversation
These will replace `SourceName` and `SourceLocation` in public APIs. They have better separation of concerns between description, resource location, and module identity. `ResourceDescriptor` and `ResourcePosition` generalize `SourceName` and `SourceLocation` respectively, without coupling to code-specific concerns like module identity. `CodePosition` will replace `SourceLocation` in public APIs where that coupling is appropriate. It generally corresponds to a "stack frame" where we require a file+position but also want to display the module (and potentially other semantic context). The "replaced" classes are likely to survive internally to optimize storage: the current design avoids having a ModuleId pointer in every source location.
toddjonker
force-pushed
the
push-xrpmwyrrvwrt
branch
from
August 24, 2026 20:31
0978821 to
0454eef
Compare
Member
Author
|
RTDocs build had transient failure, and a retry succeeded: https://app.readthedocs.org/projects/ion-fusion-java/builds/34215498/ Not sure why the checks here didn't update, and I can't seem to get GitHub to reset/retry its view. |
SharkBaitDLS
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These will replace
SourceNameandSourceLocationin public APIs. They have better separation of concerns between description, resource location, and module identity.ResourceDescriptorandResourcePositiongeneralizeSourceNameandSourceLocationrespectively, without coupling to code-specific concerns like module identity.CodePositionwill replaceSourceLocationin public APIs where that coupling is appropriate. It generally corresponds to a "stack frame" where we require a file+position but also want to display the module (and potentially other semantic context).The "replaced" classes are likely to survive internally to optimize storage: the current design avoids having a ModuleId pointer in every source location.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.