fix(data-events): metadata accepts non-string values in Unstable base spec#592
Open
pkubicki wants to merge 1 commit into
Open
fix(data-events): metadata accepts non-string values in Unstable base spec#592pkubicki wants to merge 1 commit into
pkubicki wants to merge 1 commit into
Conversation
… spec Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
The data-event
metadataschema in the Unstable base spec documents values as strings only (additionalProperties: {type: string}), which does not match the API's behaviour — the Events API accepts strings, numbers, dates, links, rich links, and monetary amounts. This over-narrow schema is what drives the SDKs to generate aRecord<string, string>type.How?
Widen
metadataadditionalPropertiestotrueon both data-event schemas in the Unstable (descriptions/0) base spec, matching the fix already applied in the Fern overrides.Related:
Generated with Claude Code