Fix/devtools popup menu material UI - #702
Open
desmonddak wants to merge 10 commits into
Open
Conversation
Use material_ui popup menu entries in the shared DevTools widget helpers so consumers using material_ui showMenu receive compatible types. Keep Flutter Material test harnesses for native dialog localization and assert the returned popup types. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Track Flutter's generated exclusions for build and platform directories so dependency resolution does not leave the package worktree dirty. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Store the module-info helper in rohd_devtools_widgets so the schematic and waveform extensions can package the same implementation from either a local or Git package source. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This pulls in Dart 3.12 or above, which formats differently. To avoid churn due to formatting as we have downstream PRs, we lower-bound to Dart 3.6 for now, eventually 3.13. Hopefully this threads the needly on formatting and deprecation until we can do an en-masse reformat once PRs are resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & Motivation
We are migrating devtools to use the latest analysis options and discovered some deprecated symbols.
Also, we found a Javascript file was needed in the shared widget support area for future widgets (module_info.js)
Importantly, we amended this PR to deploy the web app so that it is invokeable from our git page.
The assembled deployment tree becomes:
The existing deployment action publishes all of
doc/api/to thedocsbranch:Consequently, the nested build directory becomes a top-level URL beneath the ROHD Pages site:
The key point is that documentation and the compiled web app are deployed together in one operation. This prevents one deployment from erasing the other.
Related Issue(s)
None
Testing
Ran existing tests.
Backwards-compatibility
No
Documentation
None needed. This is lint cleanup, moving away from deprecated Flutter classes, and centralizing a resource file.