-
Notifications
You must be signed in to change notification settings - Fork 86
Module services api #673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
desmonddak
wants to merge
101
commits into
intel:main
Choose a base branch
from
desmonddak:module_services_api
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Module services api #673
Changes from all commits
Commits
Show all changes
101 commits
Select commit
Hold shift + click to select a range
82e900e
move synthesis naming to a common naming utility so all synthesizers …
desmonddak 85f88ce
dart 3.11 parameter_assignments pickiness
desmonddak b1de1e5
Merge branch 'main' into central_naming
desmonddak b7087c4
conflict resolved and dart format . works
desmonddak 4a55214
properly assign naming spaces for instances vs signals
desmonddak ed7be36
format issue
desmonddak ab09aed
Controllable enforcement of signal vs instance name uniqueness.
desmonddak 520d280
Refactored to Namer class. No external API changes for ROHD
desmonddak 61d0319
signal registry
desmonddak becdb36
module context name uniquification instead of signal/instance split
desmonddak a86f80c
Merge branch 'main' into central_naming
desmonddak d5904a6
cleanup of port vs signal name assumptions, constant merging and sign…
desmonddak 6dfe0f9
simplified forModule, improved code doc
desmonddak 3c90e5d
more coverage for Namer
desmonddak 42fba62
canonical names at last, even in the comments
desmonddak 6a41f8d
pesky override rule surfaced again on tutorials file
desmonddak 139280f
new keyring-based installation for dart in codespaces
desmonddak 62e4a2c
new keyring-based installation for dart in codespaces
desmonddak caecb02
keyring-style dart installation rather than holding keys
desmonddak 089faf8
new dart analyzer failure with bad override
desmonddak e015889
Merge branch 'override-bug' into new-dart
desmonddak 1232afb
Potential fix for pull request finding
desmonddak e558a4d
Orthogonalize: simplify Namer by removing instance name caching
desmonddak 8ef6820
Fix orthogonalized Namer: remove stale instanceNameOf method
desmonddak 1225df1
Clean DevTools extension analysis and formatting
desmonddak c8440c4
Keep DevTools extension changes on owning branches
desmonddak a87fa5c
added back pubkeys, and made a wget a fallback solution with loud war…
desmonddak d2760eb
Merge branch 'new-dart' into central_naming
desmonddak b7e46c0
Add instanceNameOf to Namer: cached instance-name lookup
desmonddak 0f13c7b
Move instanceNameOf stability test to central_naming
desmonddak 319706b
Wire pickName through instanceNameOf for stable instance names
desmonddak 11bc2cd
Add instance-signal namespace collision stability tests
desmonddak 3b8a8a8
consistency in naming
desmonddak 249b210
Clean up Namer allocation API
desmonddak e35373a
Stabilize naming around collapsible synth objects
desmonddak ddd96f1
heuristic to mark potentially collapsed nodes for lower priority naming
desmonddak dd07852
bias collapsible Logics for weak naming
desmonddak 9bf137e
update naming heuristic pickNames comment
desmonddak efdf60b
pana error on getter
desmonddak a783956
small change to reduce conflicts
desmonddak fa05887
small change to reduce conflicts2
desmonddak 5edbfde
small change to reduce conflicts3
desmonddak afec985
small change to reduce conflicts4
desmonddak 2e933cd
small change to reduce conflicts5
desmonddak 1f5ef48
cleaned up redundant code
desmonddak ecec474
stick with Set<SynthNet> ordering
desmonddak d27c867
fix: restore _BusSubsetForStructSlice._destination for stable instanc…
desmonddak da6c140
test: struct-slice instance names stable across repeated synth passes
desmonddak 5130601
chore: remove stale moduleOrder signal tests from naming_consistency_…
desmonddak 7fc952d
feat(Namer): expose public signalNameOf for wave-dumper and tests
desmonddak 526e05c
Add Namer.sourceLogicOf reverse name-source map
desmonddak ea3c759
cleanup copyright / signalNameOf export
desmonddak 32055a9
copyright and make method private
desmonddak 666d211
remove _nameSources backward map, relocate to FLC production
desmonddak f8979b2
Split netlist compute layer
desmonddak e6fc88a
formatted
desmonddak a9b7ada
Merge branch 'main' into netlist_pre
desmonddak f73526d
Refactor netlist synthesis helpers
desmonddak 179fea0
Fix netlist top marker selection
desmonddak 9199a40
cleanup formatting tail commas
desmonddak 0baf624
filter bank cleanup
desmonddak 8c48a81
Move filter bank example modules out of lib
desmonddak 1c7cd05
major bug fixes for LogicArray and LogicStruct
desmonddak cbda4eb
conflict resolved, sv_gen test fix
desmonddak 57fc237
inout fix
desmonddak 5a8a25f
attempt with better VS links
desmonddak 8ac1936
bump copyright
desmonddak 2001f47
major cleanup from PR comments -- complete at this point
desmonddak d43f406
much better testing of netlist passes
desmonddak ded32ed
Merge branch 'main' into netlist_pre
desmonddak 5f7999a
false positive on validation fixed
desmonddak 1cb81d9
handle inouts properly
desmonddak cbc2b2a
Merge remote-tracking branch 'origin/main' into netlist_pre
desmonddak 9f0081b
Hid generateNetlist until we have services available.
desmonddak 3721610
point to local rohd_hierarchy package, not pub
desmonddak 39c6a84
use publish_to: none for local package
desmonddak 0fc4cc9
Merge remote-tracking branch 'origin/main' into netlist_pre
desmonddak 5045b93
Merge remote-tracking branch 'upstream/main' into netlist_pre
desmonddak 043837d
compressBitRanges is an optimization test feature
desmonddak 8a1a1ed
fixes for full gate library, synth cell naming
desmonddak 2a2f614
fix authorship
desmonddak a195eac
gate catalog can be vm only
desmonddak d4e23ef
feedback fixes and prepare for merge
desmonddak cf62d8a
exhaustive gate fixture changed.
desmonddak c6e7860
performance optimizations as well as review changes related to leaf c…
desmonddak 437623e
create a structured management system for synthesized cells
desmonddak 080019b
do not store gate catalog
desmonddak b482344
preserve Logic with reserved and renameable, but allow mergeable to b…
desmonddak 6ce5fdd
Stack feature/signal-value-format-registry after netlist_pre
aee9e9c
Stack module_services_api after feature/logic-array-of
6497009
format issue
desmonddak df9aae1
clean up service model
desmonddak 60eddfa
Snapshot cleaned netlist files without branch history
desmonddak de4e6eb
link fragment fix
desmonddak 8de743f
format changed
desmonddak 4a0bb02
Merge main into module_services_api
desmonddak 44fc0ed
Preserve legacy synthesis behavior
desmonddak ab7b398
Remove unrelated branch churn
desmonddak 5885e68
Add shared signal value format registry
desmonddak fcb68e6
merge value format registry branch
desmonddak a61c6a0
align dumpSystemVerilog/dumpWaves with generateSynth/WaveDumper APIs
desmonddak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.