readme: Add CounterType and ProgrammingRestriction#375
Open
edwarddavidbaker wants to merge 2 commits into
Open
readme: Add CounterType and ProgrammingRestriction#375edwarddavidbaker wants to merge 2 commits into
edwarddavidbaker wants to merge 2 commits into
Conversation
Add documentation to describe event fields CounterType and ProgrammingRestriction.
Contributor
Author
|
Thanks for drafting readme content Ryan. What do you think about the |
rpmclaug
reviewed
Jul 13, 2026
Comment on lines
+259
to
+260
| there are several `UMask` entries, then `UMask[N]` and `MSRIndex[N]` are used to select which UMask to program, and | ||
| which MSR is written. Any of the `MSRIndex` entries is compatible with counters listed in counter fields. |
Contributor
There was a problem hiding this comment.
Suggested change
| there are several `UMask` entries, then `UMask[N]` and `MSRIndex[N]` are used to select which UMask to program, and | |
| which MSR is written. Any of the `MSRIndex` entries is compatible with counters listed in counter fields. | |
| there are multiple `UMask` entries, then `UMask` and `MSRIndex` should be used paired in their specified order. | |
| An event configured with the `N`th UMask, `UMask[N]` must write `MSRValue` to the MSR indicated at the `N`th MSRIndex, `MSRIndex[N]` . | |
| Any of the `MSRIndex` entries is compatible with counters listed in counter fields. |
Contributor
|
@edwarddavidbaker Ideally this document could remain legible in text editors; If there's a means to clarify the text description, let's start there. Can you provide an example of the sort of diagram you think would help? One possibility to help differentiate these: flowchart
MUX(MSRIndex-UMask
UMask: A,B
MSRIndex: C,D
Counter: 0,1) --> MUY{UMask: A
MSRIndex: C
Counter: 0,1}
MUX --> MUZ{UMask: B
MSRIndex: D
Counter: 0,1}
MUCX(MSRIndex-UMask-Counter
UMask: A,B
MSRIndex: C,D
Counter: 0,1) --> MUCY{UMask: A
MSRIndex: C
Counter: 0}
MUCX --> MUCZ{UMask: B
MSRIndex: D
Counter: 1}
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add documentation to describe event fields
CounterTypeandProgrammingRestriction.Pre-merge rendered markdown can be viewed at https://github.com/edwarddavidbaker/perfmon/tree/readme-updates#countertype .