Skip to content

[UR] fix use-after-free in logger during teardown #22932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kswiecicki merged 1 commit into from
Aug 13, 2026
Merged

[UR] fix use-after-free in logger during teardown #22932

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions unified-runtime/source/common/logger/ur_logger_details.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,19 @@ class Logger {
void log(const logger::LegacyMessage &p, ur_logger_level_t level,
const char *filename, const char *lineno, const char *format,
Args &&...args) {
// During process/library teardown this logger's owned sinks may already
// have been destroyed. Use a temporary stack sink instead.
if (isTearDowned) {
if (!isLegacySink && level < this->standardSinkLevel) {
return;
}
StderrSink(/*logger_name*/ "", /*skip_prefix*/ false,
/*skip_linebreak*/ false)
.log(level, filename, lineno, isLegacySink ? p.message : format,
std::forward<Args>(args)...);
return;
}

if (callbackSink && level >= this->callbackSinkLevel) {
callbackSink->log(level, filename, lineno, format, args...);
}
Expand Down
Loading