[SYCL][Driver] Match sanitizer metadata globals by prefix in .tgtsym filter - #22927
Open
zhaomaosu wants to merge 1 commit into
Open
[SYCL][Driver] Match sanitizer metadata globals by prefix in .tgtsym filter#22927zhaomaosu wants to merge 1 commit into
zhaomaosu wants to merge 1 commit into
Conversation
…filter Commit 0941896 ("[DeviceSanitizer] Make sanitizer metadata globals per-module unique") appended a per-module unique id to those names (__AsanKernelMetadata_<id>), so none of the six comparisons matched anymore and all of the metadata globals leaked into .tgtsym. Extract the check into isSpecialBitcodeSymbol() and match the sanitizer globals by prefix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 0941896 ("[DeviceSanitizer] Make sanitizer metadata globals per-module unique") appended a per-module unique id to those names (_AsanKernelMetadata), so none of the six comparisons matched anymore and all of the metadata globals leaked into .tgtsym. Extract the check into isSpecialBitcodeSymbol() and match the sanitizer globals by prefix.