Skip to content

[SYCL] Align range to SYCL 2020 specs #22889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Robertkq wants to merge 4 commits into
base: sycl
Choose a base branch
from
+27 −21
Open

[SYCL] Align range to SYCL 2020 specs #22889

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
960288a
Add missing functions & noexcept keyword
Robertkq Aug 6, 2026
d58b20a
remove comments
Robertkq Aug 6, 2026
ea37b63
add noexcept to detail::array
Robertkq Aug 6, 2026
c7f8336
remove undocumented unguarded feature & some unnecessary noexcepts, a…
Robertkq Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions sycl/include/sycl/detail/array.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,17 +61,17 @@ template <int dimensions = 1> class array {
return result;
}

size_t get(int dimension) const {
size_t get(int dimension) const noexcept {
check_dimension(dimension);
return common_array[dimension];
}

size_t &operator[](int dimension) {
size_t &operator[](int dimension) noexcept {
check_dimension(dimension);
return common_array[dimension];
}

size_t operator[](int dimension) const {
size_t operator[](int dimension) const noexcept {
check_dimension(dimension);
return common_array[dimension];
}
Expand Down
42 changes: 24 additions & 18 deletions sycl/include/sycl/range.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,22 +39,23 @@ template <int Dimensions = 1> class range : public detail::array<Dimensions> {
/* The following constructor is only available in the range class
specialization where: Dimensions==1 */
template <int N = Dimensions>
range(typename std::enable_if_t<(N == 1), size_t> dim0) : base(dim0) {}
range(typename std::enable_if_t<(N == 1), size_t> dim0) noexcept
: base(dim0) {}

/* The following constructor is only available in the range class
specialization where: Dimensions==2 */
template <int N = Dimensions>
range(typename std::enable_if_t<(N == 2), size_t> dim0, size_t dim1)
range(typename std::enable_if_t<(N == 2), size_t> dim0, size_t dim1) noexcept
: base(dim0, dim1) {}

/* The following constructor is only available in the range class
specialization where: Dimensions==3 */
template <int N = Dimensions>
range(typename std::enable_if_t<(N == 3), size_t> dim0, size_t dim1,
size_t dim2)
size_t dim2) noexcept
: base(dim0, dim1, dim2) {}

size_t size() const {
size_t size() const noexcept {
size_t size = 1;
for (int i = 0; i < Dimensions; ++i) {
size *= this->common_array[i];
Expand All @@ -68,10 +69,12 @@ template <int Dimensions = 1> class range : public detail::array<Dimensions> {
range<Dimensions> &operator=(range<Dimensions> &&rhs) = default;
range() = default;

@KornevNikita KornevNikita Aug 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
range() = default;
range() noexcept = default;


~range() = default;

// OP is: +, -, *, /, %, <<, >>, &, |, ^, &&, ||, <, >, <=, >=
#define __SYCL_GEN_OPT_BASE(op) \
friend range<Dimensions> operator op(const range<Dimensions> &lhs, \
const range<Dimensions> &rhs) { \
friend range<Dimensions> operator op( \
const range<Dimensions> &lhs, const range<Dimensions> &rhs) noexcept { \
range<Dimensions> result(lhs); \
for (int i = 0; i < Dimensions; ++i) { \
result.common_array[i] = lhs.common_array[i] op rhs.common_array[i]; \
Expand All @@ -85,7 +88,7 @@ template <int Dimensions = 1> class range : public detail::array<Dimensions> {
__SYCL_GEN_OPT_BASE(op) \
template <typename T> \
friend IntegralType<T, range<Dimensions>> operator op( \
const range<Dimensions> &lhs, const T &rhs) { \
const range<Dimensions> &lhs, const T &rhs) noexcept { \
range<Dimensions> result(lhs); \
for (int i = 0; i < Dimensions; ++i) { \
result.common_array[i] = lhs.common_array[i] op rhs; \
Expand All @@ -94,14 +97,15 @@ template <int Dimensions = 1> class range : public detail::array<Dimensions> {
} \
template <typename T> \
friend IntegralType<T, range<Dimensions>> operator op( \
const T &lhs, const range<Dimensions> &rhs) { \
const T &lhs, const range<Dimensions> &rhs) noexcept { \
range<Dimensions> result(rhs); \
for (int i = 0; i < Dimensions; ++i) { \
result.common_array[i] = lhs op rhs.common_array[i]; \
} \
return result; \
}
#else
// RFC: remove these as well?
#define __SYCL_GEN_OPT(op) \
__SYCL_GEN_OPT_BASE(op) \
friend range<Dimensions> operator op(const range<Dimensions> &lhs, \
Expand Down Expand Up @@ -144,15 +148,16 @@ template <int Dimensions = 1> class range : public detail::array<Dimensions> {

// OP is: +=, -=, *=, /=, %=, <<=, >>=, &=, |=, ^=
#define __SYCL_GEN_OPT(op) \
friend range<Dimensions> &operator op(range<Dimensions> &lhs, \
const range<Dimensions> &rhs) { \
friend range<Dimensions> &operator op( \
range<Dimensions> &lhs, const range<Dimensions> &rhs) noexcept { \
for (int i = 0; i < Dimensions; ++i) { \
lhs.common_array[i] op rhs[i]; \
} \
return lhs; \
} \
friend range<Dimensions> &operator op(range<Dimensions> &lhs, \
const size_t &rhs) { \
template <typename T> \
friend IntegralType<T, range<Dimensions>> operator op( \
range<Dimensions> &lhs, const T &rhs) noexcept { \
for (int i = 0; i < Dimensions; ++i) { \
lhs.common_array[i] op rhs; \
} \
Expand All @@ -174,7 +179,8 @@ template <int Dimensions = 1> class range : public detail::array<Dimensions> {

// OP is unary +, -
#define __SYCL_GEN_OPT(op) \
friend range<Dimensions> operator op(const range<Dimensions> &rhs) { \
friend range<Dimensions> operator op( \
const range<Dimensions> &rhs) noexcept { \
range<Dimensions> result(rhs); \
for (int i = 0; i < Dimensions; ++i) { \
result.common_array[i] = (op rhs.common_array[i]); \
Expand All @@ -189,7 +195,7 @@ template <int Dimensions = 1> class range : public detail::array<Dimensions> {

// OP is prefix ++, --
#define __SYCL_GEN_OPT(op) \
friend range<Dimensions> &operator op(range<Dimensions> &rhs) { \
friend range<Dimensions> &operator op(range<Dimensions> &rhs) noexcept { \
for (int i = 0; i < Dimensions; ++i) { \
op rhs.common_array[i]; \
} \
Expand All @@ -203,7 +209,7 @@ template <int Dimensions = 1> class range : public detail::array<Dimensions> {

// OP is postfix ++, --
#define __SYCL_GEN_OPT(op) \
friend range<Dimensions> operator op(range<Dimensions> &lhs, int) { \
friend range<Dimensions> operator op(range<Dimensions> &lhs, int) noexcept { \
range<Dimensions> old_lhs(lhs); \
for (int i = 0; i < Dimensions; ++i) { \
op lhs.common_array[i]; \
Expand All @@ -225,9 +231,9 @@ template <int Dimensions = 1> class range : public detail::array<Dimensions> {
};

#ifdef __cpp_deduction_guides
range(size_t)->range<1>;
range(size_t, size_t)->range<2>;
range(size_t, size_t, size_t)->range<3>;
range(size_t) -> range<1>;
range(size_t, size_t) -> range<2>;
range(size_t, size_t, size_t) -> range<3>;

@Robertkq Robertkq Aug 6, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

automatic change from my clang-format, I think it adheres to coding style rules of the repository

@KornevNikita KornevNikita Aug 6, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's ok, let's update this. In general try to use git clang-format HEAD~ after you've created a commit. It'll only format your changes then.

@Robertkq Robertkq Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this is my first time running into this kind of issue, maybe I don't know exactly how to fix it but I ran: python3 clang/tools/clang-format/git-clang-format HEAD~ which also with use of AI, I think should format correctly, but it left the files unmodified. Can you please tell me if with your clang-format version it really doesnt do this change?

I have this:

clang-format version 22.1.8 (Fedora 22.1.8-4.fc44)

Anyways, I can always just save without formatting and remove this, but I'd like to confirm / learn something new from this if possible :D

@KornevNikita KornevNikita Aug 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://github.com/intel/llvm/blob/sycl/clang/tools/clang-format/git-clang-format
You need to put it to your PATH. Then call git clang-format *commit* where *commit* is the commit to compare current changes with, in general it's the previous commit.

@bader bader Aug 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI uses clang-format-20 Ubuntu package.

From the log:

Setting up clang-format-20 (1:20.1.8~++20250804090239+87f0227cb601-1exp120250804210352.139) ...

#endif

} // namespace _V1
Expand Down
Loading