-
Notifications
You must be signed in to change notification settings - Fork 850
[SYCL] Use aux triple when mangling neon vectors #22877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
frengels
wants to merge
6
commits into
intel:sycl
Choose a base branch
from
frengels:neon-diagnostics
base: sycl
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+32
−7
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
652ed55
Disable diagnostics for neon attributes for SYCL device compilation
frengels 87264ce
use isTargetDevice and check for TI being set
frengels 6326994
check for bitwidth rather than specific types
frengels 53d1939
remove aux target check
frengels 1618017
apply clang-format
frengels 01fd194
fix polyvector test
frengels File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| // Does a run with a SYCL device, where neon polyvector type errors are ignored. | ||
| // afterwards compile for the host where neon polyvector type errors aren't ignored | ||
|
|
||
| // polyvector type errors get ignored with SYCL enabled | ||
| // RUN: %clang_cc1 %s -fsycl-is-device -triple spir64 -aux-triple arm64-unknown-linux-gnu -target-feature +neon -fsyntax-only -verify=quiet | ||
|
|
||
| // diagnostic for bad_poly32_t | ||
| // RUN: %clang_cc1 %s -triple arm64-unknown-linux-gnu -target-feature +neon -fsyntax-only -verify | ||
| typedef unsigned char poly8_t; | ||
| typedef unsigned short poly16_t; | ||
| typedef unsigned long poly64_t; | ||
|
|
||
| typedef unsigned int bad_poly32_t; | ||
|
|
||
| typedef __attribute__((neon_polyvector_type(16))) poly8_t poly8x16_t; | ||
| typedef __attribute__((neon_polyvector_type(8))) poly16_t poly16x8_t; | ||
| typedef __attribute__((neon_polyvector_type(2))) poly64_t poly64x2_t; | ||
|
|
||
| // this error will get ignored when running SYCL | ||
| // quiet-no-diagnostics | ||
| typedef __attribute__((neon_polyvector_type(2))) bad_poly32_t bad_poly32x2_t; | ||
| // expected-error@-1{{invalid vector element type}} | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.