Better handling around #if conditionals

[JonatanWaern]

• Refactor how we store object conds for objectdecls
• Add logic to select between hashif branches

[Copilot]

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Pull request overview

This PR improves handling of #if/#else conditionals during analysis by introducing expression evaluation support and using existence conditions to avoid reporting conflicts across mutually exclusive branches.

Changes:

• Added an evaluation module to evaluate a small subset of expressions for conditional existence checks.
• Refactored ExistCondition storage to use Arc and added helpers (exists, guaranteed_exists, guaranteed_excluded_from) to reason about conditional branches.
• Updated object/spec symbol collection and conflict detection to consider evaluated #if conditions and avoid conflicts between #if and corresponding #else.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 13 comments.

Show a summary per file

File	Description
src/analysis/templating/objects.rs	Uses ExistCondition evaluation to filter specs/decls and refines conflict reporting to ignore provably exclusive branches
src/analysis/templating/mod.rs	Exposes the new evaluation module
src/analysis/templating/evaluation.rs	Introduces expression evaluation utilities used for #if condition resolution
src/analysis/structure/toplevel.rs	Stores conditional stacks in Arc and adds existence/exclusion helpers on ExistCondition
CHANGELOG.md	Documents improved conflict handling across #if/#else and built-in version-condition behavior

Suppressed comments (1)

src/analysis/structure/toplevel.rs:97

• is_same can return true for different-length conditional stacks because zip() truncates to the shorter iterator (e.g., [A] vs [A,B] will return true). Add an explicit length equality check before the loop (or compare the full vectors) so only identical conditional stacks are treated as the same.

            (ExistCondition::Conditional(selfvec),
             ExistCondition::Conditional(othervec)) => {
                // Currently we cannt check if a condition is equivalent with another,
                // so we will only check if they are literally the same condition expression
                for ((_, cond1),
                     (_, cond2)) in selfvec.iter().zip(othervec.iter()) {
                    if cond1 != cond2 {
                        return false;
                    }
                }
                true
            },

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.