lib: introduce errors for control commands - #101
Open
jlrivasp wants to merge 1 commit into
Open
Conversation
This patch introduces custom errors when the control commands are executed. The logic is using the return codes from the PMT linux driver to indicate why the Crash Log control commands failed and include that information in the Crash Log tool debug log. There is a change made on how a PMT device executes a control command, which is relevant when a PMT device comprehends more than one endpoint: - The control command will be executed in all endpoints, independently of their return values - If at least one endpoint returns `Ok()` the control command of that PMT device will return `Ok()` as well - If all the endpoints returned `Err()` the error of the first failed endpoint will be returned as the `Err()` of the control command Signed-off-by: Rivas Paz, Jose L <jose.l.rivas.paz@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch introduces custom errors when the control commands are executed.
The logic is using the return codes from the PMT linux driver to indicate why the Crash Log control commands failed and include that information in the Crash Log tool debug log.
There is a change made on how a PMT device executes a control command, which is relevant when a PMT device comprehends more than one endpoint:
Ok()the control command of that PMT device will returnOk()as wellErr()the error of the first failed endpoint will be returned as theErr()of the control command