perf(purejava): select row-accumulated Q8 kernel#57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
models.purejava.q8BlockMajorRowAccumulatorto validated model/deployment settingspure-java-v15Why
The established Q8 block-major kernel updates a widely separated output cell after every weight block. The new Vectors strategy retains one batch-sized accumulator per active output row and scatters that row once. It is a strong win on the measured GraalVM/EPYC prefill profile but neutral on local HotSpot C2, so Models must own the runtime/topology policy rather than changing the generic Vectors default.
Selection
ROW_ACCUMULATEDrequires all of the following:Otherwise the immutable plan records the reason and selects
SCATTERED.Evidence
20.571 ms/opto4.335 ms/op(-78.9%)898.794 msto878.801 ms(-2.22%)919.981 msto886.209 ms(-3.67%)175.219 tok/sto179.479 tok/s(+2.43%)6840 msto6680 ms(-2.34%)Checks
./gradlew :models-backend-purejava:check./gradlew spotlessCheck