fix: correct RPC env var name in Foundry tutorial#629
Open
jrootcache wants to merge 1 commit into
Open
Conversation
Author
|
@przemekink @sergio-inkfnd @devknight-ink Could someone review this when you have a moment? This fixes a broken RPC config in the Foundry tutorial — the foundry.toml references ${INKSEPOLIA_RPC_URL} but the .env example defines RPC_URL. Anyone following the guide would hit a silent RPC failure on deploy. One-line fix aligns them. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the Foundry deployment tutorial (
src/pages/build/tutorials/deploying-a-smart-contract/foundry.mdx), thefoundry.tomlconfiguration references an environment variable${INKSEPOLIA_RPC_URL}for the Ink Sepolia RPC endpoint. However, the accompanying.envfile example in the same tutorial definesRPC_URL, notINKSEPOLIA_RPC_URL.This mismatch causes the RPC endpoint to resolve to an empty string, breaking deployment to Ink Sepolia for users following the tutorial.
Fix
Changed the
foundry.tomlrpc_endpoints configuration from${INKSEPOLIA_RPC_URL}to${RPC_URL}to match the variable name used in the.envexample.Why this is safe
${RPC_URL}exactly matches the variable defined in the tutorial's own.envexample (line 122).