chore: Adds separation between EventFilter and AggregationFilter on class level - #3925
Draft
awildturtok wants to merge 2 commits into
Draft
chore: Adds separation between EventFilter and AggregationFilter on class level#3925awildturtok wants to merge 2 commits into
awildturtok wants to merge 2 commits into
Conversation
They don't provide any benefit and create a larger API surface
awildturtok
commented
Jul 28, 2026
| @Setter | ||
| @CPSType(id = "PREFIX_TEXT", base = Filter.class) | ||
| public class PrefixTextFilter extends SingleColumnFilter<String> { | ||
| public class PrefixTextFilter extends EventFilter<String> { |
Collaborator
Author
There was a problem hiding this comment.
Der kann auch weg, wird nicht verwendet
Collaborator
Author
There was a problem hiding this comment.
Hat nicht in die Hierarchie gepasst und war auch Inheritance für shared behavior, was eh doof ist.
| { | ||
| "name": "indexSelector", | ||
| "type": "SELECT", | ||
| "type": "BIG_MULTI_SELECT", |
Collaborator
Author
There was a problem hiding this comment.
ups
Suggested change
| "type": "BIG_MULTI_SELECT", | |
| "type": "SELECT", |
| { | ||
| "name": "indexPlacement", | ||
| "type": "SELECT", | ||
| "type": "BIG_MULTI_SELECT", |
Collaborator
Author
There was a problem hiding this comment.
Suggested change
| "type": "BIG_MULTI_SELECT", | |
| "type": "SELECT", |
| { | ||
| "name": "resolution", | ||
| "type": "SELECT", | ||
| "type": "BIG_MULTI_SELECT", |
Collaborator
Author
There was a problem hiding this comment.
Suggested change
| "type": "BIG_MULTI_SELECT", | |
| "type": "SELECT", |
Collaborator
Author
|
Will hier noch das handling in CQConcept/FilterValue auf klassen-Filter ebene, statt Node Ebene ziehen, das ist dann etwas offensichtlicher |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also unifies SELECT-type filters into BIG_MULTI_SELECT.