[FIX] purchase_stock_ux: drop redundant price_unit merge relief - #357
Open
jcadhoc wants to merge 1 commit into
Open
[FIX] purchase_stock_ux: drop redundant price_unit merge relief#357jcadhoc wants to merge 1 commit into
jcadhoc wants to merge 1 commit into
Conversation
Contributor
|
|
El override de _prepare_merge_moves_distinct_fields sacaba price_unit de la clave de merge bajo cancel_from_order. Como stock_ux inyecta cancel_from_order=True en TODOS los merges, aflojaba tambien el merge positivo-positivo de toda confirmacion de compra (over-broad). Se elimina porque el neteo al cancelar remanente ahora lo cubre stock_ux excluyendo price_unit solo de la clave del move negativo (_prepare_merge_negative_moves_excluded_distinct_fields). El merge positivo vuelve a ser estricto por price_unit. Ver ingadhoc/stock #981. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
jcadhoc
force-pushed
the
19.0-h-123822-jc
branch
from
August 10, 2026 19:37
54eeade to
e0c0918
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contexto
Ticket 123822. Va de la mano de ingadhoc/stock#981.
El override de
_prepare_merge_moves_distinct_fieldsenpurchase_stock_uxsacabaprice_unitde la clave de merge bajocancel_from_order. Comostock_ux._merge_movesinyectacancel_from_order=Trueen todos los merges, ese override aflojaba también el merge positivo-positivo de toda confirmación de compra (over-broad): dos líneas del mismo producto con distinto precio se fusionaban siempre.Cambio
Se elimina el override. El neteo al cancelar remanente ahora lo cubre stock_ux#981 excluyendo
price_unitsolo de la clave del move negativo (_prepare_merge_negative_moves_excluded_distinct_fields). Resultado:price_unit(más correcto).Impacto a tener en cuenta
Dos líneas de OC del mismo producto con distinto precio, que antes se fusionaban en un solo move (precio promediado), ahora quedan como moves separados en la recepción. No es un bug, pero es comportamiento observable.
🤖 Generated with Claude Code