feat: Update to allow for default mode in the helm chart - #773
Open
devanbenz wants to merge 4 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the influxdb-enterprise Helm chart to optionally set defaultMode on the TLS Secret volume mounts for both meta and data StatefulSets.
Changes:
- Adds a (commented)
defaultModevalue undermeta.https.secretanddata.https.secretinvalues.yaml. - Renders
defaultModeinto the TLS Secret volume spec in both meta and data StatefulSet templates when configured.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| charts/influxdb-enterprise/values.yaml | Documents a new optional defaultMode value for TLS secret volumes (commented example). |
| charts/influxdb-enterprise/templates/meta-statefulset.yaml | Conditionally emits defaultMode for the meta TLS Secret volume. |
| charts/influxdb-enterprise/templates/data-statefulset.yaml | Conditionally emits defaultMode for the data TLS Secret volume. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.