Skip to content

build: use go version 1.27 - #5650

Merged
mhilton merged 1 commit into
masterfrom
mhilton/go-version-1.27
Aug 25, 2026
Merged

build: use go version 1.27#5650
mhilton merged 1 commit into
masterfrom
mhilton/go-version-1.27

Conversation

@mhilton

@mhilton mhilton commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Update the go version used to build flux to 1.27. This replaces version 1.25, which is no longer supported.

Checklist

Dear Author 👋, the following checks should be completed (or explicitly dismissed) before merging.

  • ✏️ Write a PR description, regardless of triviality, to include the value of this PR
  • 🔗 Reference related issues
  • 🏃 Test cases are included to exercise the new code
  • 🧪 If new packages are being introduced to stdlib, link to Working Group discussion notes and ensure it lands under experimental/
  • 📖 If language features are changing, ensure docs/Spec.md has been updated

Dear Reviewer(s) 👋, you are responsible (among others) for ensuring the completeness and quality of the above before approval.

@mhilton
mhilton requested a review from a team as a code owner August 25, 2026 06:27
Update the go version used to build flux to 1.27. This replaces version
1.25, which is no longer supported.
@mhilton
mhilton force-pushed the mhilton/go-version-1.27 branch from 7dd4b22 to f6a52c1 Compare August 25, 2026 06:30
@mhilton
mhilton requested a lite review from Copilot and removed request for a team August 25, 2026 06:31

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Flux’s build environment from Go 1.25 to Go 1.27.

Changes:

  • Upgrades Go base images to 1.27.
  • Updates CircleCI configuration to version 2.1.
  • Modifies the Windows build setup.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Summary Review status
Dockerfile_build Uses Go 1.27 build images. No blocking comments.
.circleci/config.yml Updates CircleCI syntax and Windows build configuration. Critical (3 votes): Keep the heredoc operator unescaped; otherwise Bash will not recognize <<EOF, causing the Windows job to fail.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .circleci/config.yml
# an ssh agent to be set up, which doesn't work on Circle's Windows executors.
# See https://github.com/rust-lang/cargo/issues/1851#issuecomment-450130685
cat <<EOF >> ~/.cargo/config
cat \<<EOF >> ~/.cargo/config

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This escape is necessary to stop circle CI treating <<EOF >> as a pipe variable.

@mhilton
mhilton requested a review from a team August 25, 2026 06:41
@mhilton
mhilton merged commit cbc9061 into master Aug 25, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants