Release 0.2.6 - #28
Merged
Merged
Conversation
There are cases where we never need the `Equivalent` abstraction. This may not lead to much performance difference, if any, but it should at least be a little lighter burden on the compiler. (cherry picked from commit 4da89f315654e967b2332331218e8a5da04dc394)
At first glance this may seem worse because it's roughly duplicating the `unsafe` code. However, these are now placed in a dedicated module where the parallels are apparent, and they should be more direct for their respective use-cases. * For disjoint key lookup in a map, we don't need to produce a `Result` that we're just going to turn into panics anyway. * For disjoint indices in a slice, we don't need to deal with `Option`, and we can drop our own unsafe implementation here in favor of the standard library once we update to MSRV 1.86. (cherry picked from commit ddb0316dc25e12fb0ecda55f0a4e754dd62e6e5c)
(cherry picked from commit 323b6797f047494cee90ff5e47faf1e742192671)
This makes sure we use consistent messages for index bounds checks, without so much repetition. (cherry picked from commit 49532eb10bc096014100a837c994cccbee22e493)
(cherry picked from commit eae6655867ee1496629bae84e86502909f35dbf0)
(cherry picked from commit ae475950a3cc18bd914aec74ea411cca170e2b38)
(cherry picked from commit 417437d1aae0a963015a6a4fad13a512df562a05)
(cherry picked from commit 79f7bd948506f3e52224b8eb096611576a6cd19b)
(cherry picked from commit be7ffd0d154c06f76152b6884ee44f88eebe68aa)
(cherry picked from commit 41760c52bbfdd6c7cb43331246c813506d825a49)
(cherry picked from commit 64f4a06684dd4ed06dc6629dd8bbefc59394b2c9)
(cherry picked from commit 1c2be7b00c5bb61f654210355d1e9f0d9be03956)
(cherry picked from commit 21963654e41f86f396a2ba6d9582ccd8eb7df52c)
(cherry picked from commit c95da18c97d2742fe8731f36e81c1d04f0620c6a)
(cherry picked from commit af93b43ecd62d28deb59a6ac23f98bd115475eaf)
(cherry picked from commit ada540e17cc7d8f38359f7d83c225e38f367c86b)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.