Skip to content

[BUGFIX] Qualify referrer column in referrer-domain queries #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
einpraegsam merged 1 commit into from
Jul 22, 2026
Merged

[BUGFIX] Qualify referrer column in referrer-domain queries #76

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Classes/Domain/Repository/PagevisitRepository.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,11 +414,11 @@ protected function getPageVisitsPerReferrerSql(FilterDto $filter): string
{
/** @var SiteService $siteService */
$siteService = GeneralUtility::makeInstance(SiteService::class);
$sql = 'SELECT SUBSTRING_INDEX(SUBSTRING_INDEX(referrer, \'://\', -1), \'/\', 1) as referrer_domain, COUNT(*) as total_pagevisits';
$sql = 'SELECT SUBSTRING_INDEX(SUBSTRING_INDEX(pv.referrer, \'://\', -1), \'/\', 1) as referrer_domain, COUNT(*) as total_pagevisits';
$sql .= ' FROM ' . Pagevisit::TABLE_NAME . ' pv';
$sql .= ' WHERE pv.deleted = 0 and pv.hidden = 0';
$sql .= ' AND pv.referrer != \'\'';
$sql .= ' AND referrer NOT REGEXP "' . $siteService->getAllDomainsForWhereClause() . '"';
$sql .= ' AND pv.referrer NOT REGEXP "' . $siteService->getAllDomainsForWhereClause() . '"';
$sql .= $this->extendWhereClauseWithFilterSearchterms($filter, 'pv', 'referrer');
$sql .= $this->extendWhereClauseWithFilterTime($filter, true, 'pv');
$sql .= $this->extendWhereClauseWithFilterSite($filter);
Expand All @@ -429,7 +429,7 @@ protected function getPageVisitsPerReferrerSql(FilterDto $filter): string

protected function getIdentifiedVisitorsPerReferrerSql(FilterDto $filter): string
{
$sql = 'SELECT SUBSTRING_INDEX(SUBSTRING_INDEX(referrer, \'://\', -1), \'/\', 1) as referrer_domain, COUNT(DISTINCT pv.visitor) as identified_visitor_count';
$sql = 'SELECT SUBSTRING_INDEX(SUBSTRING_INDEX(pv.referrer, \'://\', -1), \'/\', 1) as referrer_domain, COUNT(DISTINCT pv.visitor) as identified_visitor_count';
$sql .= ' FROM ' . Pagevisit::TABLE_NAME . ' pv';
$sql .= ' INNER JOIN ' . Visitor::TABLE_NAME . ' v ON pv.visitor=v.uid AND v.identified=1 AND v.hidden=0 AND v.deleted=0';
$sql .= ' WHERE pv.deleted = 0 and pv.hidden = 0 AND pv.referrer != \'\'';
Expand Down
Loading