Skip to content

Remove unused navigation, datastore, and hilt-navigation dependencies - #122

Merged
in-jun merged 1 commit into
mainfrom
fix/build-gradle
Jul 18, 2026
Merged

Remove unused navigation, datastore, and hilt-navigation dependencies#122
in-jun merged 1 commit into
mainfrom
fix/build-gradle

Conversation

@in-jun

@in-jun in-jun commented Jul 18, 2026

Copy link
Copy Markdown
Owner

Drops three declared-but-unused dependencies from app/build.gradle.kts and their version-catalog entries. None of them are referenced anywhere in the codebase:

  • androidx.navigation:navigation-compose — navigation is a hand-rolled when (screen) in MainActivity; there is no NavHost/NavController.
  • androidx.datastore:datastore-preferences — persistence goes through SharedPreferences/EncryptedSharedPreferences/Room; no DataStore usage exists.
  • androidx.hilt:hilt-navigation-compose — the ViewModel is obtained via by viewModels(), not hiltViewModel().

Also removes the now-orphaned navigationCompose and datastore version entries. The hiltNavigationCompose version ref is kept since androidx-hilt-work and androidx-hilt-compiler still reference it.

:app:compileDebugKotlin and :core-sync:compileKotlin both pass.

Fixes #43

@in-jun in-jun left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified each removal against the source tree:

  • navigation-compose — no NavHost/NavController/rememberNavController anywhere; navigation is the hand-rolled when (screen) in MainActivity. Safe.
  • datastore-preferences — no DataStore references; persistence is SharedPreferences/EncryptedSharedPreferences/Room. Safe.
  • hilt-navigation-compose — the ViewModel is retrieved via by viewModels() (MainActivity.kt:42), and the @HiltViewModel annotation resolves from dagger.hilt.android.lifecycle (hilt-android), not this artifact. Safe.

Version-catalog cleanup checks out too: navigationCompose and datastore were each only referenced by the removed aliases, while hiltNavigationCompose is correctly kept since androidx-hilt-work and androidx-hilt-compiler still point at it. No dangling references remain and there's no runtime surface affected.

Looks good.

@in-jun
in-jun merged commit 0db1b1e into main Jul 18, 2026
1 check passed
@in-jun
in-jun deleted the fix/build-gradle branch July 18, 2026 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove unused navigation-compose, datastore-preferences, and hilt-navigation-compose dependencies

1 participant