Remove unused navigation, datastore, and hilt-navigation dependencies - #122
Merged
Conversation
in-jun
commented
Jul 18, 2026
in-jun
left a comment
Owner
Author
There was a problem hiding this comment.
Verified each removal against the source tree:
navigation-compose— noNavHost/NavController/rememberNavControlleranywhere; navigation is the hand-rolledwhen (screen)inMainActivity. Safe.datastore-preferences— noDataStorereferences; persistence is SharedPreferences/EncryptedSharedPreferences/Room. Safe.hilt-navigation-compose— the ViewModel is retrieved viaby viewModels()(MainActivity.kt:42), and the@HiltViewModelannotation resolves fromdagger.hilt.android.lifecycle(hilt-android), not this artifact. Safe.
Version-catalog cleanup checks out too: navigationCompose and datastore were each only referenced by the removed aliases, while hiltNavigationCompose is correctly kept since androidx-hilt-work and androidx-hilt-compiler still point at it. No dangling references remain and there's no runtime surface affected.
Looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops three declared-but-unused dependencies from
app/build.gradle.ktsand their version-catalog entries. None of them are referenced anywhere in the codebase:androidx.navigation:navigation-compose— navigation is a hand-rolledwhen (screen)inMainActivity; there is noNavHost/NavController.androidx.datastore:datastore-preferences— persistence goes throughSharedPreferences/EncryptedSharedPreferences/Room; noDataStoreusage exists.androidx.hilt:hilt-navigation-compose— the ViewModel is obtained viaby viewModels(), nothiltViewModel().Also removes the now-orphaned
navigationComposeanddatastoreversion entries. ThehiltNavigationComposeversion ref is kept sinceandroidx-hilt-workandandroidx-hilt-compilerstill reference it.:app:compileDebugKotlinand:core-sync:compileKotlinboth pass.Fixes #43