Skip to content

Make Settings scrollable and fix sync-mode radio semantics #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
in-jun merged 1 commit into from
Jul 18, 2026
Merged

Make Settings scrollable and fix sync-mode radio semantics #116

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions app/src/main/kotlin/dev/injun/remotesync/ui/screens/SettingsScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@ import androidx.compose.foundation.layout.Spacer
import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.layout.height
import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.rememberScrollState
import androidx.compose.foundation.selection.selectable
import androidx.compose.foundation.verticalScroll
import androidx.compose.material.icons.Icons
import androidx.compose.material.icons.automirrored.filled.ArrowBack
import androidx.compose.material3.Icon
Expand All @@ -23,6 +25,7 @@ import androidx.compose.runtime.Composable
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.platform.LocalContext
import androidx.compose.ui.semantics.Role
import androidx.compose.ui.unit.dp
import dev.injun.remotesync.sync.AppSettings
import dev.injun.remotesync.sync.SyncMode
Expand Down Expand Up @@ -51,6 +54,7 @@ fun SettingsScreen(
Column(
Modifier
.padding(padding)
.verticalScroll(rememberScrollState())
.padding(16.dp)
.fillMaxWidth(),
) {
Expand Down Expand Up @@ -113,11 +117,11 @@ private fun ModeOption(
Row(
Modifier
.fillMaxWidth()
.selectable(selected = selected, onClick = onSelect)
.selectable(selected = selected, role = Role.RadioButton, onClick = onSelect)
.padding(vertical = 8.dp),
verticalAlignment = Alignment.CenterVertically,
) {
RadioButton(selected = selected, onClick = onSelect)
RadioButton(selected = selected, onClick = null)
Column(Modifier.padding(start = 8.dp)) {
Text(title, style = MaterialTheme.typography.bodyLarge)
Text(detail, style = MaterialTheme.typography.bodySmall)
Expand Down
Loading