fix(client): make ACL domain lists take effect reliably - #641
Open
lsr00ter wants to merge 1 commit into
Open
Conversation
Member
|
This so called fix doesn't make sense at all. |
Author
It will trigger a working reload after change the Proxy/Direct Domain List and save/apply, not like before, always shows nothing change |
lsr00ter
force-pushed
the
fix-exclude-china-domain-rules
branch
from
July 5, 2026 16:34
2a4a7df to
305e861
Compare
Ensure always-proxy domains are routed before fallback handling in non-custom modes, while preserving dedicated UDP routing precedence. Make resource-backed ACL file edits update checksum fields under the control section so LuCI has a real UCI change to apply and homeproxy reloads after saving.
lsr00ter
force-pushed
the
fix-exclude-china-domain-rules
branch
from
July 7, 2026 09:39
6e4a99f to
1a32fca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix ACL domain list changes not reliably taking effect in client mode.
This updates the proxy/direct domain list handling so that:
Root Cause
The proxy/direct domain lists are stored in files under
/etc/homeproxy/resources/, not directly as UCI list values. When only those files changed, LuCI could write the new content but still not mark the HomeProxy config as changed, so Apply/Restart was not triggered.There were also two runtime gaps:
proxy-domainrule sets could be generated without a matching route rule.direct_list.txtgenerated sing-box domain rules, but did not generate dnsmasqnftset=rules, so transparent routing could still only see the resolved IP and fall through to mode defaults.Changes
proxy-domaintomain-out.nftset=rules fordirect_list.txtto populate:homeproxy_wan_direct_addr_v4homeproxy_wan_direct_addr_v6when IPv6 is enabledValidation
Tested on ImmortalWrt with
bypass_mainland_chinaandredirect_tproxymode.Verified that:
homeproxy_wan_direct_addr_v4.main-dnsviamain-out.Local checks: