Fix alternate form flag for %x testing stale signed value - #248
Closed
iliaal wants to merge 1 commit into
Closed
Conversation
The alternate-form branch for %x/%X gated the "0x" prefix on i_num, which is only ever assigned by the signed/unsigned decimal conversions. A standalone "%#x" with a nonzero value therefore printed no prefix (i_num still held its zero initializer), while "%d %#x" consumed the earlier conversion's value and could print a prefix for zero. Test the unsigned conversion result ui_num instead, matching the "0" check the octal case already performs on the converted digits.
Owner
Author
|
Upstream: php#23410 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the alternate-form flag for %x/%X gating the 0x prefix on i_num, which is only ever assigned by the decimal conversions; a standalone %#x printed no prefix and %d %#x consumed the earlier conversion's value.