feat: take the frontend origin and cluster zone from configuration - #31
Merged
Conversation
The CORS allow-list pinned one deployment's frontend origin in the binary, and the chart defaulted WebAuthn and the tenant zone to our own domain — so another install would silently inherit it and fail somewhere far from the cause. - read CORS_ALLOWED_ORIGINS from the environment; the Vite dev ports stay hardcoded, they are a local convenience no deployment would configure - derive the WebAuthn RP ID, its origins and CORS from one frontendHost value - require frontendHost and cluster.domain rather than defaulting them - pass FRONTEND_HOST and CLUSTER_DOMAIN through deploy Signed-off-by: vthwang <vthwang.work@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.