fix: default the monitor restart window to 1 minute - #30
Merged
Conversation
A restart kept /monitor/workloads in alarm for 15 minutes after the pod had recovered, so a 1-minute poller re-notified on every check until the window expired. - MONITOR_RESTART_WINDOW_MIN default 15 -> 1 (config, .env.example, Helm values) - note in .env.example that the value should track the poller's interval A crash loop still alarms on its own via CrashLoopBackOff, so persistent failures stay visible; what the shorter window drops is a single restart that lands between two polls. Signed-off-by: vthwang <vthwang.work@gmail.com>
The surrounding entries state what the value does, not how to pick it. Signed-off-by: vthwang <vthwang.work@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolved #29