fix: traefik values in rancher - #28
Merged
Merged
Conversation
Every fpp cluster is Rancher-managed, and Rancher owns the HelmChartConfig object (objectset.rio.cattle.io/owner-name: managed-chart-config). Applying it with kubectl holds until the next sync or upgrade and is then reverted, which is the same thing that kept wiping ingress-nginx's default-ssl-certificate. The values belong in the cluster's rkeConfig.chartValues; the manifest stays for clusters Rancher does not manage. Trimmed to what is not already a chart default. Only the redirect and isDefaultClass were doing anything — the providers block and the websecure TLS flag matched the chart's own values, and websecure TLS is kept explicit only because its silent absence takes down HTTPS everywhere. Also worth knowing when verifying: a values change re-runs the helm-install job whether or not it changes anything, so a completed job proves nothing. dev has the proof — the job re-ran while the pod stayed older than it, because the mistyped paths rendered identical args. Read the rendered args instead. Signed-off-by: vthwang <vthwang.work@gmail.com>
The block now carries a sibling entry so it is obvious the map is added to rather than replaced, and says plainly that the chart ships no values schema — a misspelled or misplaced key is accepted, emits no argument, and reads as a working config. Also completes the hand-applied ClusterRole further down, which was missing traefik.io/middlewares and cert-manager.io/certificates. It is the list a manually built cluster copies, so without them Middlewares and custom-domain certificates fail there while the Helm-deployed chart works. Signed-off-by: vthwang <vthwang.work@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.