feat: advertise TSP alongside DIDComm across all four components - #24
Closed
vthwang wants to merge 1 commit into
Closed
feat: advertise TSP alongside DIDComm across all four components#24vthwang wants to merge 1 commit into
vthwang wants to merge 1 commit into
Conversation
The images are built with TSP; the recipes were not. Turn it on in the four places that have to agree, and fix one that was already wrong. `services.tsp = true` in both VTA recipes publishes a `#tsp` `TSPTransport` entry from DID log v1, pointing at the same mediator as the DIDComm entry. `[messaging]` deliberately gains no `protocols` key — omitted, setup derives the minted mediator's transports from `[services]`, which is the only value that keeps the two in step. The VTC's `messaging.transports` is a repair, not an addition: it is required, so `vtc setup --from` had no chance of parsing this recipe on any vtc image from #929 onward, TSP or no TSP. `identity.transport` in the webvh recipe was likewise not neutral by absence — the daemon reads absent as `both`, so a TSP-carrying build has been advertising `TSPTransport` against a mediator whose recipe said `["didcomm"]`. The mediator's own `protocols` has no runtime effect on a prebuilt image; it records which image the session expects. Two things to know before this ships: - The VTA image must be built `--features tsp`. Setup refuses the flag otherwise, so an image predating TSP no longer builds a session. - `vta_only` points at the platform stack's mediator via `kind = "existing"`, and nothing upstream verifies that mediator carries TSP. Rebuild the platform stack on a TSP-enabled mediator image first: `#tsp` is first in the preference order, so peers pick it and fail rather than fall back to DIDComm. Signed-off-by: vthwang <vthwang.work@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.